node-slack-sdk icon indicating copy to clipboard operation
node-slack-sdk copied to clipboard

fix(1528): better warnings about webclient fallbacks

Open edwmurph opened this issue 3 years ago • 1 comments

Summary

fixes https://github.com/slackapi/node-slack-sdk/issues/1528

this PR updates the warning logic for the conversation api to better match this logic:

If the top-level text does not exist and any of its attachments does not have fallback property, we still should warn it (we can say "You should have either top-level text or fallback in all the attachments" if we want to make it more accurate). If all the attachments have the fallback property, no warnings should be printed.

Requirements

edwmurph avatar Sep 02 '22 12:09 edwmurph

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 02 '22 12:09 CLAassistant