java-slack-sdk icon indicating copy to clipboard operation
java-slack-sdk copied to clipboard

AmazonS3InstallationService add constructor

Open smallufo opened this issue 2 years ago • 2 comments

This pull request may resolve https://github.com/slackapi/java-slack-sdk/issues/1165

Category (place an x in each of the [ ])

  • [x] bolt (Bolt for Java)
  • [ ] bolt-{sub modules} (Bolt for Java - optional modules)
  • [ ] slack-api-client (Slack API Clients)
  • [ ] slack-api-model (Slack API Data Models)
  • [ ] slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • [ ] slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

smallufo avatar Jun 10 '23 18:06 smallufo

Thanks for the contribution! Before we can merge this, we need @smallufo to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar Jun 10 '23 18:06 salesforce-cla[bot]

Codecov Report

Merging #1168 (7081ab6) into main (25cd87e) will decrease coverage by 0.06%. The diff coverage is 9.09%.

@@             Coverage Diff              @@
##               main    #1168      +/-   ##
============================================
- Coverage     75.25%   75.20%   -0.06%     
- Complexity     4004     4005       +1     
============================================
  Files           430      430              
  Lines         12528    12538      +10     
  Branches       1261     1262       +1     
============================================
+ Hits           9428     9429       +1     
- Misses         2355     2362       +7     
- Partials        745      747       +2     
Impacted Files Coverage Δ
...t/service/builtin/AmazonS3InstallationService.java 47.79% <9.09%> (-3.21%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 12 '23 08:06 codecov[bot]