java-slack-sdk icon indicating copy to clipboard operation
java-slack-sdk copied to clipboard

Upgrade slf4j-api to 2.0

Open seratch opened this issue 3 years ago • 3 comments

slf4j project released a new major version - 2.0.

According to the migration guide, ~~it's safe to upgrade the dependency in this project but it requires a minor version bump of this SDK.~~ EDIT: I might be wrong. Perhaps, if we release a new version with slf4j-api 2.0 dependency, real-world apps such as Spring Boot web apps would be suffered from behavior changes. We should hold off upgrading to 2.0 for the time being.

Category (place an x in each of the [ ])

  • [x] bolt (Bolt for Java)
  • [x] bolt-{sub modules} (Bolt for Java - optional modules)
  • [x] slack-api-client (Slack API Clients)
  • [x] slack-api-model (Slack API Data Models)
  • [x] slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • [x] slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. :bow:

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

seratch avatar Aug 22 '22 22:08 seratch

Still waiting for logback-classic 1.3.0 release: https://github.com/qos-ch/logback/tags

seratch avatar Aug 23 '22 03:08 seratch

EDIT: I might be wrong. Perhaps, if we release a new version with slf4j-api 2.0 dependency, real-world apps such as Spring Boot web apps would be suffered from behavior changes. We should hold off upgrading to 2.0 for the time being.

seratch avatar Aug 23 '22 08:08 seratch

Another factor we should consider for this upgrade is that logback-classic 1.4 and perhaps other implementations of sfl4j-api v2 no longer supports Java 1.8. Yes, the version is long-lived old version but this SDK still supports the version for broader audience.

seratch avatar Nov 08 '22 02:11 seratch