additive icon indicating copy to clipboard operation
additive copied to clipboard

Replace LambDynamicLights with Shimmer

Open Felix14-v2 opened this issue 2 years ago • 9 comments

Shimmer is a great project with a flexible configuration possibilities for users and devs, including colored dynamic lighting. And it already can work with Sodium 0.5 :) Maybe give it a chance?

By the way, LambDynamicLights has been seen causing a huge performance drops on some devices, including mine. Here's an example: https://discord.com/channels/977987490742935652/1125634282128408626/1125696662313111592

Demo from discord: https://pomf2.lain.la/f/ca5t9oyd.mp4

Felix14-v2 avatar Sep 04 '23 19:09 Felix14-v2

Shimmer doesn't work on Quilt because the mod is returning null from a method that is supposed to be not-null, which somehow works on Fabric, but doesn't on Quilt (as it shouldn't).

Gaming32 avatar Sep 08 '23 21:09 Gaming32

And the shimmer dev has some... weird... opinions on when they should add quilt support. According to them, quilt will be supported when quilt removes the WIP banner from their front page

MenacingPerson avatar Sep 09 '23 02:09 MenacingPerson

The weird thing is that the only place I found where it doesn't work is that they're returning null from a method that should never have null returned from it. It's sloppy code and it's breaking on Quilt because Quilt expects that code to be written properly.

Gaming32 avatar Sep 09 '23 03:09 Gaming32

Well, if they don't want to fix it then reporting it to the quilt devs will probably work

MenacingPerson avatar Sep 09 '23 03:09 MenacingPerson

Yeah, Quilt could probably handle that a bit better (like mimicking Fabric), but honestly it's just luck at this point that that doesn't crash on Fabric.

Gaming32 avatar Sep 09 '23 03:09 Gaming32

Shimmer also has a lot more stuff than LDL, that doesn't fit under OF compat. I wonder how laggy it is on low-end PCs.

MenacingPerson avatar Sep 09 '23 03:09 MenacingPerson

I wonder how laggy it is on low-end PCs.

Still better than LDL, which is broken on 1.20 (see attached video)

Felix14-v2 avatar Sep 10 '23 21:09 Felix14-v2

At least LDL loads

Gaming32 avatar Sep 10 '23 23:09 Gaming32

Still better than LDL, which is broken on 1.20 (see attached video)

But that's a bug, surely. I meant that generally it seems to be doing a lot more, and it might not fit for Additive especially with coloured lights and stuff.

MenacingPerson avatar Sep 11 '23 11:09 MenacingPerson