escort icon indicating copy to clipboard operation
escort copied to clipboard

Status

Open behlec opened this issue 8 years ago • 3 comments

Is this project dead?

I would like to submit a pull request but the tests seem dysfunctional?

behlec avatar Nov 18 '17 14:11 behlec

Hi, just a random stranger passing by. I just checked the test suite and run the tests using: Ruby-2.4.2 RSpec 3.7.0 All gems needed with latest versions

And it seems the tests are still using old RSpec code that changed. it's a shame to not see your pull request, I will submit one with fixed tests and updated ruby and gems versions and you can retry see if that helped.

thegreyfellow avatar Nov 18 '17 21:11 thegreyfellow

Hi,

I have a small feature that allows to enable a "help" command. This allows the option to get help via app help cmd instead of app cmd --help. I was just wondering whether I should bother with tests. The changes needed are quite small.

I think I will do the following: check for myself if my feature works. (Can test against --help) Submit a pull request without tests.

If you submit your pull requests, send me a note and I will see if I can add some tests for my features.

It would be really great if the tests were running again, your efforts would be greatly appreciated.

behlec avatar Nov 19 '17 08:11 behlec

Hi behlec, I submitted a pull request yesterday sorry I did not mention you at the time its PR#16 . Also opened issues #8 and #9 but I don't think they are related to you're future changes, they are more like edge cases.

thegreyfellow avatar Nov 19 '17 11:11 thegreyfellow