elfeed icon indicating copy to clipboard operation
elfeed copied to clipboard
verified publisher icon skeeto

Add mode-class property where appropriate

Open mssdvd opened this issue 4 years ago • 3 comments

This PR adds the property mode-class with value special to elfeed-search-mode and elfeed-show-mode.

According to the elisp docs every "special" mode should have this property.

mssdvd avatar Oct 25 '21 18:10 mssdvd

The motivation behind this PR is a performance issue that is triggered when Flycheck is enabled for elfeed-search buffers.

global-flycheck-mode enables Flycheck where it makes sense (e.g. not in the minibuffer, fundamental-mode etc.). For special buffers like elfeed-search the only way to let know Flycheck what to do is the property mode-class.

Without this patch Emacs freeze for many seconds, sometimes minutes.

mssdvd avatar Nov 05 '21 18:11 mssdvd

Following #317, With global-flycheck-mode on, my Emacs hang 2 minutes when update feeds. After disable it, Emacs only hang a few seconds. Snip20220505_23

@skeeto Hope you can merge this.

jiacai2050 avatar May 05 '22 14:05 jiacai2050 

(setq flycheck-global-modes '(not . (elfeed-search-mode)))

For now, users can use this config to disable flycheck in elfeed-search-mode.

jiacai2050 avatar May 08 '22 02:05 jiacai2050