sitespeed.io icon indicating copy to clipboard operation
sitespeed.io copied to clipboard

Budgets for Groups of Pages

Open shaqb opened this issue 3 years ago • 9 comments

Feature/improvement

Currently there is way to define a budget.json in the following format for a particular url/alias:

{
 "budget": {
   "myAlias": {
      "timings": {
        "SpeedIndex": 3000
      }
    },
    "timings": {
      "SpeedIndex":1000
    }
 }

We're rolling out sitespeed.io across our entire organisation and the common request coming back is it is possible to have the budgets defined for a group of pages/aliases? The reason for this is we have vastly different technology for different parts of a system, so the teams would like to be able to have a specific set of budgets for a group of pages, then another budget for another group.

Currently the only way to do this is one set of budgets per url/page. Is it possible to support a group of pages in the budget config so we could have

"budget": {
    "timings": {
      "firstPaint": 1000,
      "pageLoadTime": 2000,
      "fullyLoaded": 2000,
      "FirstVisualChange": 1000,
      "LastVisualChange": 1200,
      "SpeedIndex": 1200,
      "PerceptualSpeedIndex":1200,
      "VisualReadiness": 200,
      "VisualComplete95": 1190
    }

Assigned to [Alias1, Alias2, Alias3]

and

"budget": {
    "timings": {
      "firstPaint": 1500,
      "pageLoadTime": 2500,
      "fullyLoaded": 2500,
      "FirstVisualChange": 1500,
      "LastVisualChange": 1500,
      "SpeedIndex": 1500,
      "PerceptualSpeedIndex":1500,
      "VisualReadiness": 300,
      "VisualComplete95": 1500
    }

Assigned to [Alias4, Alias5, Alias6]

shaqb avatar May 19 '22 09:05 shaqb

Hi @shaqb thanks for creating the issue. Hmm, I need to think about how this can be done, let me come back about it after the weekend.

soulgalore avatar May 19 '22 20:05 soulgalore

Thanks @soulgalore!

shaqb avatar May 20 '22 06:05 shaqb

Think we can bundle that with #3570 the thing is that to make it happen we need to come up with a new (preferable backward compatible) format. Don't think that will happen in a couple of months though, when I get some time my number one priority is to get the online version of sitespeed.io testable so others can give me feedback on it.

soulgalore avatar May 23 '22 14:05 soulgalore

Hey @soulgalore - sorry for the delay - was on a long holiday with my family! If you need a beta tester for your online version of sitespeed.io, I'll happily volunteer!

shaqb avatar Jun 09 '22 08:06 shaqb

Thanks Peter!

On Thu, 19 May 2022 at 21:14, Peter Hedenskog @.***> wrote:

Hi @shaqb https://github.com/shaqb thanks for creating the issue. Hmm, I need to think about how this can be done, let me come back about it after the weekend.

— Reply to this email directly, view it on GitHub https://github.com/sitespeedio/sitespeed.io/issues/3654#issuecomment-1132161934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWBYKI6NMFSHNKDM4XBM33VK2OJJANCNFSM5WLPMWPA . You are receiving this because you were mentioned.Message ID: @.***>

shaqb avatar Oct 11 '22 08:10 shaqb

Haven't been able to do anything about this yet.

soulgalore avatar Oct 12 '22 13:10 soulgalore

@shaqb let me know if you are still a happy volunteer for testing out the online version? Probably have a rough version for testing the coming weeks.

soulgalore avatar Jun 26 '23 14:06 soulgalore

Hi Peter - yep definitely happy to!

On 26 Jun 2023, at 15:23, Peter Hedenskog @.***> wrote:

@shaqb https://github.com/shaqb let me know if you are still a happy volunteer for testing out the online version? Probably have a rough version for testing the coming weeks.

— Reply to this email directly, view it on GitHub https://github.com/sitespeedio/sitespeed.io/issues/3654#issuecomment-1607601862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWBYKLPGLYRPEKV3ZMWK5LXNGLPHANCNFSM5WLPMWPA. You are receiving this because you were mentioned.

shaqb avatar Jun 26 '23 14:06 shaqb

Hey @soulgalore - just wondered if you'd had another chance to look at this. I'm working for a new company now and they also have multiple teams that would like this feature

shaqb avatar Sep 06 '23 13:09 shaqb