browsertime icon indicating copy to clipboard operation
browsertime copied to clipboard

[Firefox] Present the graph of visual metrics in profiler without the need of profiler screenshots.

Open sefeng211 opened this issue 5 years ago • 4 comments

Using browsertime to collect firefox profiles allow the profiler to present a visual metrics graph, here's an example, but this graph would only be presented if you have screenshots as one of the enabled profiler feature (--firefox.geckoProfilerParams.features "screenshots").

Maybe we should allow showing this graph without the need of this feature?

sefeng211 avatar Feb 27 '20 20:02 sefeng211

Hi @sefeng211 very cool, I did't know it was included in the profiler. So what need to be done in Browsertime, I didn't fully get that?

soulgalore avatar Feb 28 '20 06:02 soulgalore

@soulgalore I believe what @sefeng211 is suggesting is that instead of doing

browsertime.js --video --firefox.geckoProfiler --firefox.geckoProfilerParams.features "screenshots"

to generate a profile with screenshots AND use visual metrics, it should be possible to do:

browsertime.js --video --firefox.geckoProfiler

and use the frames from the video as the screenshots in the profile.

freshstrangemusic avatar Feb 28 '20 17:02 freshstrangemusic

Yup exactly ^! Basically just remove the requirement of --firefox.geckoProfilerParams.features "screenshots"

sefeng211 avatar Feb 28 '20 17:02 sefeng211

Yes, feel free to change (and merge), you guys are the experts on Firefox stuff so please go ahead :)

soulgalore avatar Feb 28 '20 18:02 soulgalore