[Firefox] Present the graph of visual metrics in profiler without the need of profiler screenshots.
Using browsertime to collect firefox profiles allow the profiler to present a visual metrics graph, here's an example, but this graph would only be presented if you have screenshots as one of the enabled profiler feature (--firefox.geckoProfilerParams.features "screenshots").
Maybe we should allow showing this graph without the need of this feature?
Hi @sefeng211 very cool, I did't know it was included in the profiler. So what need to be done in Browsertime, I didn't fully get that?
@soulgalore I believe what @sefeng211 is suggesting is that instead of doing
browsertime.js --video --firefox.geckoProfiler --firefox.geckoProfilerParams.features "screenshots"
to generate a profile with screenshots AND use visual metrics, it should be possible to do:
browsertime.js --video --firefox.geckoProfiler
and use the frames from the video as the screenshots in the profile.
Yup exactly ^! Basically just remove the requirement of --firefox.geckoProfilerParams.features "screenshots"
Yes, feel free to change (and merge), you guys are the experts on Firefox stuff so please go ahead :)