Colin Douch

Results 66 comments of Colin Douch

@jbdalido Feel free - I've been a bit bogged down with other stuff. You can see my initial work in https://github.com/sinkingpoint/VictoriaMetrics/tree/exemplars_exemplar - it's gotten as far as writing exemplars to...

Also: I recognise that this would be a breaking change should we decide to go down this path - not sure how to handle it (or even if we should,...

@felipesere I have a patch at https://github.com/sinkingpoint/alertmanager/tree/sinkingpoint/receiver_name_metrics that I'm testing internally and then will PR if there's interest

It's been working well for us. I'll PR it today

Partially solves #2618 / #2498

I think the helper function is still useful - itherwise we would have a bunch of redundant IO logic everywhere. There's nothing stopping you calling the helper every time you...

Thanks for the review @simonpasquier ! I've added in an acceptance test to test the behaviour. Detecting duplicate names is an interesting problem... Yes - we can implement the ConflictDelegate...

Mine is at https://github.com/sinkingpoint/kiora/blob/main/cmd/kiora/config/graph.go if you want something to work off of. I don't really have the bandwidth to support it

Apologies for leaving this... I think that sounds reasonable. Will push that today

@alimehrabikoshki I've just updated the PR