singularityhub
(maint) update docker-compose.yml to version 3
Update docker-compose.yml from version 1 to 3. Not as straight forward as it seemed.
Signed-off-by: Vladislav Doster [email protected]
Oh hmm, interesting. To play devil's advocate, I use a fairly recent version of docker-compose, and haven't had issue running the config files. If we update to a newer one, then folks with older versions will probably lose functionality. What are the reasons to do this, and why is it a better approach than the current?
https://docs.docker.com/compose/compose-file/compose-versioning/#version-3
You gain new syntax and allows us to take advantage of new docker engine features.
We weren't able to use docker swarm or Kubernetes with version 1.
Oh, neat! That definitely is an improvement. If you've tested this and it works as expected, we should be good! I would ask if you could also update the https example? https://github.com/singularityhub/sregistry/tree/master/https
And to have a quick discussion about releases - merging into master will actually deploy a container with the current release in the VERSION file, so I think since this is a fairly big change we'd want to also bump that to 1.1.31, otherwise it will build over the previous container version.
You never have to apologize for helping to make the project better - I'm here and ready when you are!
https://github.com/singularityhub/sregistry/pull/405 updated docker-compose.yml to use the new format and I think this can be closed.
