sim icon indicating copy to clipboard operation
sim copied to clipboard

Fix/UI Cursor pointer on docs

Open Khanisic opened this issue 3 months ago • 2 comments

Summary

This PR adds cursor pointer styling to improve clarity and interactivity across key UI elements. Specifically, cursor pointer has been added to: • the theme toggler in the navbar • sidebar navigation buttons • the language selector button in the navbar

These elements are all interactive, so adding proper pointer feedback improves usability and aligns with standard UI behavior.

Type of Change

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Breaking change
  • [ ] Documentation
  • [X] Other: UI Improvement

Testing

Confirmed that the cursor changes to the correct pointer type on hover.

Checklist

  • [X] Code follows project style guidelines
  • [X] Self-reviewed my changes
  • [ ] Tests added/updated and passing
  • [X] No new warnings introduced
  • [X] I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

image image image

Khanisic avatar Nov 14 '25 01:11 Khanisic

@Khanisic is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 14 '25 01:11 vercel[bot]

Greptile Overview

Greptile Summary

This PR has significant scope creep - while titled "Fix/UI Cursor pointer on docs", only 3 of 30 files actually relate to cursor pointer styling. The cursor pointer changes themselves add redundant cursor-pointer classes to button elements, which already have pointer cursors by default in browsers.

Major Issues:

  • 27 of 30 files contain unrelated changes including terminal height adjustments, popover enhancements, deployment refactoring, brand color updates, email styling, provider changes, store modifications, and executor logic changes
  • globals.css was modified in violation of the project's custom instruction which explicitly states to avoid editing this file unless absolutely necessary
  • The cursor pointer additions are redundant on <button> elements since browsers already apply cursor: pointer by default

Recommendations:

  • Split this PR into multiple focused PRs - one for cursor pointer changes (if needed at all), one for terminal/UI improvements, one for deployment refactoring, one for brand color updates, etc.
  • Remove the cursor-pointer classes from button elements as they're unnecessary
  • Revert the globals.css change and move the terminal height adjustment to the local component file instead

Confidence Score: 1/5

  • This PR is not safe to merge due to massive scope creep and custom instruction violations
  • Score of 1 reflects: (1) 27 of 30 files contain unrelated changes not mentioned in PR description, (2) direct violation of custom instruction against editing globals.css, (3) redundant cursor-pointer classes on button elements, (4) mixing of unrelated features makes it difficult to review and roll back if issues arise
  • apps/sim/app/globals.css needs immediate attention for custom instruction violation. apps/sim/executor/execution/block-executor.ts contains significant logic changes that should be in a separate PR and thoroughly reviewed

Important Files Changed

File Analysis

Filename Score Overview
apps/docs/components/ui/theme-toggle.tsx 4/5 Added redundant cursor-pointer class to button element (browsers already apply pointer cursor to buttons)
apps/docs/components/docs-layout/sidebar-components.tsx 4/5 Added redundant cursor-pointer class to button element
apps/docs/components/ui/language-dropdown.tsx 4/5 Added redundant cursor-pointer class to two button elements
apps/sim/app/globals.css 1/5 Changed terminal height - violates custom instruction to avoid editing globals.css, unrelated to PR description
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx 2/5 Changed default expanded height constant - unrelated to cursor pointer changes
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/hooks/use-child-deployment.ts 3/5 Refactored deployment status checking logic to use new API endpoint - unrelated to cursor pointer changes
apps/sim/executor/execution/block-executor.ts 4/5 Significant changes to execution logic and error handling - unrelated to cursor pointer changes

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant UI as UI Components
    participant CSS as Browser CSS
    participant Files as Other Files
    
    Dev->>UI: Add cursor-pointer to buttons
    Note over UI,CSS: cursor-pointer redundant on buttons
    CSS-->>UI: Buttons already have pointer cursor
    
    Dev->>Files: Add unrelated changes
    Note over Files: 27 of 30 files unrelated to PR
    Files->>Files: Terminal height adjustments
    Files->>Files: Popover enhancements
    Files->>Files: Deployment refactoring
    Files->>Files: Brand color updates
    Files->>Files: Provider changes
    Files->>Files: Store modifications
    
    Dev->>UI: Modify globals.css
    Note over UI: Violates custom instruction

greptile-apps[bot] avatar Nov 14 '25 01:11 greptile-apps[bot]

this is resolved

waleedlatif1 avatar Dec 13 '25 03:12 waleedlatif1