rust-tools.nvim icon indicating copy to clipboard operation
rust-tools.nvim copied to clipboard

feat(inlay-hints): add inlay hints toggle function

Open TheFedaikin opened this issue 2 years ago • 10 comments

Closes #345

TheFedaikin avatar Mar 08 '23 06:03 TheFedaikin

ooooh, this is exactly what I've been looking for! I'm not the maintainer, but I would add that updating this section of the readme would be useful.

other than that, I think this is great. I'm already using your branch in my config.

adabarx avatar Apr 08 '23 16:04 adabarx

I am glad this works for you! Feel free to report if anything breaks, I'll try to patch this PR to fix that.

About the documentation, you are absolutely correct - I think I was too focused on the actual functionality that I forgot to improve that. I'll do that tomorrow, but from the looks of it, this repo is pretty slow nowadays, so I am not expecting this to be merged anytime soon, which is unfortunate.

TheFedaikin avatar Apr 08 '23 18:04 TheFedaikin

Thanks everyone for the interest in this PR!

I updated implementation, created an external command for toggle and addressed the documentation comment.

Feel free to report regressions or/and add your suggestions for this issue here, it's been a very helpful feedback so far!

TheFedaikin avatar May 03 '23 13:05 TheFedaikin

I changed the PR name so it's clear what it's current implementation is doing. Originally I was thinking about also exposing enabled and disabled state externally, but opted out of it. If you can think about the use-case that would need that feature, please let me know, but this works well for me at this moment.

TheFedaikin avatar May 03 '23 13:05 TheFedaikin

I'm not sure if @simrat39 is active these days. I've been using https://github.com/lvimuser/lsp-inlayhints.nvim, which already has this option. It works perfectly with rust-tools. It also shows more information I think.

utkarshgupta137 avatar May 03 '23 13:05 utkarshgupta137

Just wanted to chime in that this feature would be super useful as I'd like to be able to start with them disabled but have the ability to easily show them 😄

lcrownover avatar May 07 '23 23:05 lcrownover

I've pulled this in https://github.com/MunifTanjim/rust-tools.nvim/tree/patched

MunifTanjim avatar May 20 '23 06:05 MunifTanjim

Damn would love this to be merged.

penso avatar Jun 03 '23 11:06 penso

How close is this to getting merged?

nico-mayora avatar Jun 23 '23 16:06 nico-mayora

@nico-mayora I don't want to be alarmist but I don't think the author has time for this project and there's absolutely no signs he will be back so it's probably easier to fork and cherry-pick changes that you want for yourself and use it. Alternatively we can wait (or find if it exists) for official fork so it can move forward.

TheFedaikin avatar Jun 27 '23 15:06 TheFedaikin