app icon indicating copy to clipboard operation
app copied to clipboard

Run parsley validation on page reload.

Open FozzieHi opened this issue 3 years ago • 4 comments

Currently if you input some bad data into a form with parsley validation and refresh the page, the bad data is not outlined: image

This PR rechecks parsley validation on page reload using the PerformanceNavigationTiming.type property. See compatibility table. Now on page reload, the user is shown current validation status: image

FozzieHi avatar Feb 16 '22 22:02 FozzieHi

Note: We might not even need the check for the getEntriesByType method in performance. However, I couldn't find the browsers we're targeting in the contributing document. It does seem widely supported. @nguyenkims it'd be nice to have a defined list of compatible browsers we're targeting with the web app for implementing front end features.

FozzieHi avatar Feb 16 '22 22:02 FozzieHi

@FozzieHi hey I'm not sure how to reproduce this bug. If we refresh a page, says the /dashboard/custom_alias one, all filled up data is reset right?

nguyenkims avatar Feb 21 '22 14:02 nguyenkims

@nguyenkims If I go to custom alias, fill out the alias name then refresh the page then the alias name is still filled in. If I completely refresh the page (using Ctrl + F5) the data is reset. Maybe this is a specific browser feature? I'm using Firefox.

FozzieHi avatar Feb 21 '22 15:02 FozzieHi

I run the test with Chrome and Safari, this seems indeed to be a Firefox specific behavior.

nguyenkims avatar Feb 24 '22 12:02 nguyenkims