selection icon indicating copy to clipboard operation
selection copied to clipboard

feat(react): expose viewportRef prop in SelectionArea

Open rlesniak opened this issue 2 years ago • 4 comments

close: #193

Feel free to modify this PR. Feature is backward compatible I tested it in my project and look that it worked exactly I described in my stackblitz

rlesniak avatar Jul 26 '23 10:07 rlesniak

I also noticed wrong typing in react props, so fixed it image

rlesniak avatar Jul 26 '23 11:07 rlesniak

Awesome, thank you! I'll take a closer look at the end of the week :)

simonwep avatar Jul 26 '23 11:07 simonwep

Hey, I'm a bit confused, the issue described in #193 is something in the vanilla / core package. How does this PR fix this issue?

simonwep avatar Jul 30 '23 08:07 simonwep

Ouu so my fault. Somehow I assumed that it is about react. Anyway, I had exact same issue in React. Fix here is working for me and I am satisfied that I can attach scrollable div to this lib and use it as earlier.

rlesniak avatar Jul 31 '23 14:07 rlesniak