SimpleValueGraphs.jl icon indicating copy to clipboard operation
SimpleValueGraphs.jl copied to clipboard
verified publisher icon simonschoelly

Starting to fix #37

Open gdalle opened this issue 4 years ago • 2 comments

Hi there :wave: I tried to code a first version of rem_vertex! by drawing inspiration from the one in LightGraphs.jl. It only works on ValGraph for now, because I wanted to discuss the implementation. I didn't add tests because they seem to be broken for this part of the codebase (which is probably why this line is commented?). Anyway, let me now what you think!

gdalle avatar May 09 '21 11:05 gdalle

Hi, I did not have time yet to look to much into this PR, but it is highly appreciated. Will try to do that this week. The tests are a bit of a mess indeed, I will check where they would go best. You are right, that we should definitely model this after LightGraphs, so that there are no surprises.

simonschoelly avatar May 17 '21 22:05 simonschoelly

So I would suggest you add tests to interface/modifiers.jl - the tests for rem_edge! are already there. Eventually I will clean this up and just move these tests then somewhere else.

simonschoelly avatar May 24 '21 21:05 simonschoelly