UnFlow icon indicating copy to clipboard operation
UnFlow copied to clipboard

Intended behaviour of np.roll?

Open johannes-graeter opened this issue 7 years ago • 0 comments

Hi Simon, I came across a line of code that made me think: https://github.com/simonmeister/UnFlow/blob/ddb4bd32f762168ed38849f736b6a7d2094b0042/src/e2eflow/core/input.py#L178-L179

If I understand correctly np.roll with axis=None will first flatten the array and then roll. Is that the intention? In order to shift the training examples to the desired training position it seems to me that np.roll(..., axis=0) would be the desired behaviour (in order to roll complete rows of the array).

Thanks :) Johannes

johannes-graeter avatar Dec 12 '18 09:12 johannes-graeter