Simmo Saan

I suppose that's why it was implemented as an object here, but it might not be wise to depend on some undocumented behavior.

> Moreover, `dune` uses `-strict-format` by default That's nice, I wasn't aware. > @sim642 would you like to try making a PR for this change? It should be fairly easy,...

> Given that this PRand the `-strict-formats` change will touch the same parts of the code, I think, may I grab the idea and include the fix in the PR...

I'm surprised by the format CI failure: ``` ocamlformat: ignoring "test/mangle/test.ml" (syntax error) File "test/mangle/test.ml", line 8, characters 0-6: 8 | Mangle.mangle (`Suffix "suf") "foo";; ^^^^^^ Error: Syntax error ```...

> About polymorphic variants vs non-polymorphic variants for the type. I'm curious now: why have you chosen polymorphic ones? Is it to avoid having to open the module? I didn't...

I now implemented the suggested changes, thanks to the reminder from release.

I haven't looked closely at this, but my preliminary question is whether this new diffing mechanism is strongly tied to #738. On first glance, it seems like they should be...

Some of the incremental tests might have been written in a way that assumes AST comparison: for example, a change being made to a function with the purpose of reanalyzing...

> * Fix generation of asserts about pointers to malloced-memory. With malloced memory, there are (`tmp`-)variables of type `void*` that point to it. The assertions that are currently generated for...

> However, the executable one obtains crashes with a failed assertion: > > ``` > a.out: hash.c:606: hash_initialize: Assertion `table___0->tuning == & default_tuning' failed. > Aborted (core dumped) > ```...