droppy icon indicating copy to clipboard operation
droppy copied to clipboard

Unable to manipulate file with a name containing colon.

Open w32zhong opened this issue 8 years ago • 2 comments

Is this designed on purpose?

w32zhong avatar Oct 18 '17 22:10 w32zhong

Colons (and a number of other characters, see here) are forbidden as filenames on NTFS, and colons specifically also cause issues in the macOS Finder. These limitations don't apply when the server runs on Linux with a typical filesystem like ext4.

Right now, I forbid all characters that could get problematic, but if there's a cross-platform way to detect the file system in use on the server, I can communicate that fact back to the web client and allow those characters.

silverwind avatar Oct 19 '17 04:10 silverwind

@silverwind Thank you for your comment. The thing is, I do not think having Droppy support those special chars in filename really depends on underlying filesystem in a sense that if colon is not permitted on that filesystem, we can never create it and view any filename containing colon in any way. If user want to create such filename via Droppy, just return a creation error (because OS will return that error) instead of making assumption on file naming rules.

If we remove all these restrictions in Droppy, at least ext4 users will not find themselves helpless when they trying to delete a file via Droopy, because Droppy API will prohibit it in the first place. And NTFS users will not run into this problem anyway because they do not need to.

w32zhong avatar Oct 19 '17 21:10 w32zhong