Implement subscription change
Currently you can change a subscription by simply altering the plan attached to that subscription. The downside of this is that the entire history also gets changed.
An example where this model fails is:
-
subscriptionA hasplanB with themetered featureC, and 0 amount ofmetered featureincluded in plan B - you change this plan for the same
subscriptionA, toplanD, having the samemetered featureassociated, but having Emetered featureincluded inplanD.
In this case, if the customer has consumed some metered features before the plan change, then there will be no charge for the amount E of metered feature, included in plan D.
I see two solutions for this:
Solution A
- When you change the plan for a subscription, it won't touch the previous plans included in that subscription. In other words preserve the plan history without altering it if the plan has changed. Right now when you change a plan, it will change it for all history.
Solution B
- When you change the plan for a subscription, end that subscription with the old plan at the end of the billing cycle and start a new subscription with the new plan starting with the next billing cycle.
Remains TBD which one is better.
This issue will be automatically closed on Tue, 17 Jan 2017 due to the lack of activity (comments or updates). Closed issues that remain inactive for a long period of time might also get automatically locked.
If you think this is an error or you want to keep the issue from being closed reply with a comment or apply the keep-open label to permanently disable auto-closing.
cc: @calind, @pdobrescu, @vtemian