libpalaso Renamed SIL.Media to SIL.Windows.Forms.Media

This change is

Jun 04 '24 07:06 josephmyers

I wonder if it might be best to split SIL.Media into a utility DLL and a Forms DLL, as we have with the other things. There are only a small handful of WinForms-specific things here.

Aug 01 '24 20:08 tombogle

LibPalaso Tests

17 files ±0 17 suites ±0 8m 33s :stopwatch: +22s 4 883 tests ±0 4 652 :white_check_mark: ±0 231 :zzz: ±0 0 :x: ±0 4 902 runs ±0 4 658 :white_check_mark: ±0 244 :zzz: ±0 0 :x: ±0

Results for commit 0b7a9aff. ± Comparison against base commit db9df03c.

Aug 01 '24 20:08 github-actions[bot]

If it's a small handful, would there be any value in absorbing it into an existing library? Is the benefit of a separate dll enough to justify its cost?

Aug 02 '24 07:08 josephmyers

I don't see any logical fit anywhere else. The only possible place would be Core, but everything uses thats, so I think it would be less than ideal to put it there. Eventually, HearThis will probably become a non-WinForms app (or get a non-WinForms cousin), so breaking the functionality up really does make sense. I don't know enough about the architecture of Bloom, but it would be another possible candidate for using stuff in SIL.Media if it were not WinFoms dependent.

Aug 02 '24 12:08 tombogle

I'm also fine leaving it as is. The only thing this PR does is make the name less misleading.

Aug 15 '24 07:08 josephmyers

Bloom will need to have this teased apart eventually, so that is going to be helpful whenever it happens. However, I think this rename is useful as a standalone change. It needs a +semver:major in the commit message. Also, unfortunately, this has languished long enough to have many merge conflicts.

Aug 21 '25 16:08 andrew-polk

Yes, and I've changed roles as well, so this unfortunately now falls outside my purview. It may be easier to start from scratch.

Aug 27 '25 12:08 josephmyers