libpalaso icon indicating copy to clipboard operation
libpalaso copied to clipboard

Integrate Bloom's Copyright & License dialog

Open papeh opened this issue 2 years ago • 2 comments

The Bloom team has implemented an easier-to-understand CC license picker. Could this be integrated into the Palaso ClearShare library?

The Bloom team has also designed (but not implemented) an entire new image picker, which we will want to integrate whenever it gets implemented (currently not a priority for the Bloom team).

Palaso ClearShare's current dialog: image

Bloom's current dialogs: image

Bloom's proposed dialog: https://www.figma.com/file/V5wQEtjPkOuLNY2Yu6UoUW4Z/Bloom-Edit-Tab?type=design&node-id=3326-7453&mode=design

papeh avatar Jul 11 '23 16:07 papeh

Note, the old forms are WinForms. The new ones run in a browser (components are built using React).

andrew-polk avatar Jul 11 '23 16:07 andrew-polk

With our browser-based components, we would, of course, like to continue the tradition of SIL LSDev co-ownership/maintenance that we have with libpalaso. However this time around, we think a collection of independent libraries is a better way forward. In rare cases (config-r, comicaljs), we are building components as independent NPM libraries from the start. In other cases, where it isn't clear if anyone else will use a component, we'll wait for another project to actually be ready to use the component before going to the work of spinning it off.

hatton avatar Jul 11 '23 19:07 hatton

Since Bloom's dialog is a React component, even if there's demand for it to become an independent NPM library, that won't be in libpalaso.

imnasnainaec avatar Feb 13 '25 15:02 imnasnainaec

Yeah nowadays it is react. But at the time of this issue, the Bloom copyright and license dialog might still have been winforms. So if you really wanted, that code is available and could be used. But yeah probably better to use the new web-based on in a webview2 control if you can.

hatton avatar Feb 13 '25 18:02 hatton

@papeh , Was your thought perhaps to reimplement a similar design in WinForms, or possibly to use the React component inside a WinForms dialog with a WebView2 control?

tombogle avatar Feb 13 '25 18:02 tombogle