reactgrid icon indicating copy to clipboard operation
reactgrid copied to clipboard

Add disableFixedEditCells to prevent fixed css styling in edit cell

Open jbavari opened this issue 1 year ago • 4 comments

In our usage of the React grid component, when we edit a cell, we do not want the cell to remain in CSS fixed styling.

I've added a disableFixedEditCells which attempts to place the cell in an absolute position placed on top of the cell being edited.

This should fall back to sane defaults to prevent any other users from needing to enable or change fixed positioning on cells.

jbavari avatar Jun 05 '24 02:06 jbavari

@jbavari Sorry, but it won't work because the CellEditor is rendered outside of Panes. It won't work on frozen panes

webloopbox avatar Jun 05 '24 15:06 webloopbox

I'd be happy to implement a solution that covers working for frozen panes. Do you have any guidance on how/where to start to cover that case? Our team really needs the box to not be in fixed position for our application.

jbavari avatar Jun 05 '24 17:06 jbavari

@jbavari I've tested it again and see that the absolute top position, which is determined by multiplying the row index (location.row.idx) by the row height, generates a couple of problems:

  • A scenario where row heights have different values results in an incorrect top position
  • The edited cell overflows the sticky panes.

I will also try to come up with a solution

https://github.com/silevis/reactgrid/assets/60100557/c16005fe-9856-4e65-8f8c-c9c976325488

webloopbox avatar Jun 07 '24 12:06 webloopbox

v5 won't have the floating editor anyway :)

MichaelMatejko avatar Jun 11 '24 15:06 MichaelMatejko