prom-client icon indicating copy to clipboard operation
prom-client copied to clipboard

Compliancy the default metrics with Prometheus Naming Convention

Open izonder opened this issue 6 years ago • 2 comments

Checking the default metrics with promtool complains about breaking compliancy with official Prometheus Naming Convention (https://prometheus.io/docs/practices/naming/), e.g.:

$ curl -s http://localhost:3000/metrics | promtool check metrics
nodejs_active_handles_total non-counter metrics should not have "_total" suffix
nodejs_active_requests_total non-counter metrics should not have "_total" suffix

izonder avatar Aug 27 '19 10:08 izonder

PR very much welcome fixing all metric names!

SimenB avatar Aug 27 '19 11:08 SimenB

@SimenB please review the PR

izonder avatar Aug 29 '19 09:08 izonder