sigstore-python icon indicating copy to clipboard operation
sigstore-python copied to clipboard

cli: deprecate `verify --cert`

Open woodruffw opened this issue 3 years ago • 5 comments

The long form (--certificate) is the intended option.

Closes #149.

Signed-off-by: William Woodruff [email protected]

woodruffw avatar Jul 05 '22 17:07 woodruffw

As a demo:

$ sigstore verify --cert README.md.crt README.md
WARNING:sigstore._cli:--cert has been replaced with --certificate and will be removed in an upcoming stable release

woodruffw avatar Jul 05 '22 17:07 woodruffw

Does cosign still use --cert? I had a quick grep and it looks like it still does.

I'll leave the judgement call to you but I tend to think that it's more important that our CLI is compatible with cosign than to be symmetrical or consistent in general.

tetsuo-cpp avatar Jul 06 '22 03:07 tetsuo-cpp

I'll leave the judgement call to you but I tend to think that it's more important that our CLI is compatible with cosign than to be symmetrical or consistent in general.

Yeah, that's why I wanted to get @di's opinion -- IMO we're divergent enough at this point that it makes sense to make changes that improve our UX, but this is admittedly a very small example of one of those changes 🙂

woodruffw avatar Jul 06 '22 14:07 woodruffw

I think we should just support both as the same option for now, with no deprecation warning, to ensure this remains intuitive for cosign users as well as make sense for new users.

di avatar Jul 06 '22 14:07 di

Sounds good. I'll mark this as a draft then, and we can revisit if necessary.

woodruffw avatar Jul 06 '22 14:07 woodruffw

Very stale and not unanimous, so closing 🙂

woodruffw avatar Jun 07 '24 21:06 woodruffw