sigstore-python icon indicating copy to clipboard operation
sigstore-python copied to clipboard

Reenable interrogate

Open tetsuo-cpp opened this issue 3 years ago • 1 comments

As part of #12, we've disabled interrogate while we're in the initial phases of development. When things are looking more solid, let's add a docstring for everything and reenable interrogate.

tetsuo-cpp avatar Mar 27 '22 06:03 tetsuo-cpp

From https://github.com/trailofbits/sigstore-python/pull/12#discussion_r835860090

Shouldn't we still try to aim to have a docstring for everything?

IMO, a docstring for everything is overkill, but I could be convinced otherwise

di avatar Apr 08 '22 18:04 di

Doc coverage as of #344:

========= Coverage for /Users/william/devel/sigstore-python/sigstore/ ==========
----------------------------------- Summary ------------------------------------
| Name                             |    Total |    Miss |    Cover |    Cover% |
|----------------------------------|----------|---------|----------|-----------|
| __init__.py                      |        1 |       0 |        1 |      100% |
| __main__.py                      |        1 |       0 |        1 |      100% |
| _sign.py                         |        7 |       0 |        7 |      100% |
| _utils.py                        |        9 |       0 |        9 |      100% |
| _internal/__init__.py            |        1 |       1 |        0 |        0% |
| _internal/ctfe.py                |        9 |       2 |        7 |       78% |
| _internal/merkle.py              |        3 |       1 |        2 |       67% |
| _internal/sct.py                 |        3 |       1 |        2 |       67% |
| _internal/set.py                 |        3 |       1 |        2 |       67% |
| _internal/fulcio/__init__.py     |        1 |       0 |        1 |      100% |
| _internal/fulcio/client.py       |       26 |      16 |       10 |       38% |
| _internal/oidc/__init__.py       |        4 |       0 |        4 |      100% |
| _internal/oidc/ambient.py        |        6 |       0 |        6 |      100% |
| _internal/oidc/issuer.py         |        4 |       0 |        4 |      100% |
| _internal/oidc/oauth.py          |       22 |      21 |        1 |        5% |
| _internal/rekor/__init__.py      |        1 |       0 |        1 |      100% |
| _internal/rekor/client.py        |       33 |      25 |        8 |       24% |
| _store/__init__.py               |        1 |       1 |        0 |        0% |
| _verify/__init__.py              |        1 |       0 |        1 |      100% |
| _verify/models.py                |       11 |       2 |        9 |       82% |
| _verify/policy.py                |       20 |       9 |       11 |       55% |
| _verify/verifier.py              |        9 |       4 |        5 |       56% |
|----------------------------------|----------|---------|----------|-----------|
| TOTAL                            |      176 |      84 |       92 |     52.3% |
--------------- RESULT: FAILED (minimum: 100.0%, actual: 52.3%) ----------------

Per: interrogate -c pyproject.toml . -v

woodruffw avatar Dec 13 '22 20:12 woodruffw