sigstore
MacOS speed
Investigate the speed on OSX. The unit tests seem to be slow. It could be because the runners are not as fast
The issue is not speed to the best of my knowledge. After playing with this last night I realized that the test will hang and appear to be slow, but in reality it just is not running the signing. I identified this by running the benchmarking, and notice it hanging for signing and verifying YOLOP for about 90 minutes, but then was able to manually sign and verify the ~220 MB model in about 2 minutes when running manually. Additional Darwin ships with Bash version 3.X.X (or at least mine did):
/bin/bash --version
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin23)
Bash v4 is required for the associative arrays used in benchmarking. I am considering a re-write to build a JSON summary file with jq instead. This does introduce another depedency, however I think it would harden our support for other platform. Thoughts?
ah, good catch. I've assigned the issue to you.
@mihaimaruseac wrote some benchmark code in Python a while back. @mihaimaruseac would you be able to share?
I will, need to clean some stuff first. It will remove the need for #182 though.
@Gregory-Pereira the issue is that the CI under .github/workflows is slow, not the so much benchmarking
The tests are fast now with refactoring and using hatch test with parallelism