lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard
verified publisher icon sigp

feat: add tests for filtering GET /beacon/pool/attestations

Open gap-editor opened this issue 1 year ago • 9 comments

Added test_get_beacon_pool_attestations_filtered to verify that the /eth/v2/beacon/pool/attestations endpoint correctly filters attestations based on the slot and committee_index query parameters, as required by #7312.

gap-editor avatar Apr 12 '25 18:04 gap-editor

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 12 '25 18:04 CLAassistant

@macladson did i do good or no?

gap-editor avatar Apr 13 '25 11:04 gap-editor

@gap-editor no, need to get rid of those commits from stable

michaelsproul avatar Apr 13 '25 11:04 michaelsproul

@michaelsproul

gap-editor avatar May 02 '25 19:05 gap-editor

This pull request has merge conflicts. Could you please resolve them @gap-editor? 🙏

mergify[bot] avatar May 02 '25 19:05 mergify[bot]

Looks like there are some conflicts. Can you update your branch? (Either merge or rebase on unstable)

@macladson done. if smth is wrong may be better to reopen PR in unstable branch?

gap-editor avatar May 03 '25 09:05 gap-editor

@macladson

gap-editor avatar May 13 '25 20:05 gap-editor

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

mergify[bot] avatar May 15 '25 07:05 mergify[bot]

Some required checks have failed. Could you please take a look @gap-editor? 🙏

mergify[bot] avatar Jun 05 '25 14:06 mergify[bot]

Hi @gap-editor, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.

mergify[bot] avatar Jul 05 '25 14:07 mergify[bot]