Signal-iOS icon indicating copy to clipboard operation
Signal-iOS copied to clipboard

#6079 - Double tapping on a quotedmessageview using voiceover

Open MarlowBrown opened this issue 6 months ago • 2 comments

Contributor checklist

  • [x] My commits are rebased on the latest main branch
  • [x] My commits are in nice logical chunks
  • [x] My contribution is fully baked and is ready to be merged as is
  • [x] I have tested my contribution on these devices:
  • iPhone 12, iOS 18.4.1

Description

This PR fixes #6079 by adding additional text to the accessibility string for a quoted message view. This extra text informs the user that by double-tapping on the view, they will be taken to the original message.

https://github.com/user-attachments/assets/46604490-4bcd-4c95-b05c-e1a6be2585c3

(Edit) Since my change involves touching some of the locale files, what is the process for updating all locale files to be accurate? Do a series of human translators do it, or is there a script for using an AI translator? Can you give me some insight, Sasha?

MarlowBrown avatar Jul 26 '25 23:07 MarlowBrown

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 26 '25 12:10 github-actions[bot]

Keep open

On Sun, Oct 26, 2025 at 7:26 AM github-actions[bot] < @.***> wrote:

github-actions[bot] left a comment (signalapp/Signal-iOS#6088) https://github.com/signalapp/Signal-iOS/pull/6088#issuecomment-3448474216

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-iOS/pull/6088#issuecomment-3448474216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI3H5DPD5RUFOASIRTI4RDT3ZS4Y7AVCNFSM6AAAAACCODHRR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINBYGQ3TIMRRGY . You are receiving this because you authored the thread.Message ID: @.***>

MarlowBrown avatar Oct 26 '25 15:10 MarlowBrown