Signal-iOS icon indicating copy to clipboard operation
Signal-iOS copied to clipboard

#5488 Drag and Drop Images

Open MarlowBrown opened this issue 8 months ago • 4 comments

Contributor checklist

  • [x] My commits are rebased on the latest main branch
  • [x] My commits are in nice logical chunks
  • [x] My contribution is fully baked and is ready to be merged as is
  • [x] I have tested my contribution on these devices:
  • iPhone 12 iOS 18.4.1

Description

This pull request introduces (fixes #5488) a common feature in many chatting applications, but is not currently present in Signal. This feature allows the user to drag and drop images straight into any conversation thread. I tested this by dragging and dropping different image UTIs (pngs, jpegs, etc) along with images that are and arent sticker size (images below 512 pixels).

Test dragging into text input bar

https://github.com/user-attachments/assets/4b94dc2c-4b76-45df-8642-269d18b70927

Test dragging into conversation view controller view

https://github.com/user-attachments/assets/2782bf20-488c-4304-9310-0a543f458986

MarlowBrown avatar May 16 '25 20:05 MarlowBrown

Looking at this PR taught me that dragging and dropping images is even possible in iOS! 🤩 Seems like a pretty nifty feature to have.

MMachado05 avatar May 27 '25 20:05 MMachado05

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 26 '25 12:08 github-actions[bot]

Keep open

On Tue, Aug 26, 2025 at 7:27 AM github-actions[bot] < @.***> wrote:

github-actions[bot] left a comment (signalapp/Signal-iOS#6053) https://github.com/signalapp/Signal-iOS/pull/6053#issuecomment-3223969943

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-iOS/pull/6053#issuecomment-3223969943, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI3H5DO3VWWO2HJZTENJWCD3PRHC7AVCNFSM6AAAAAB5JTMZLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMRTHE3DSOJUGM . You are receiving this because you authored the thread.Message ID: @.***>

MarlowBrown avatar Aug 26 '25 13:08 MarlowBrown

Please keep open. This polish will help the app become more appealing to the youth that love using other messaging apps.

gabefair avatar Oct 18 '25 21:10 gabefair