Signal-iOS icon indicating copy to clipboard operation
Signal-iOS copied to clipboard

Disappearing messages: setting them above 4 weeks create inconsistent behavior

Open ggrelet opened this issue 1 year ago • 1 comments

  • [x] I have searched open and closed issues for duplicates
  • [x] I am submitting a bug report for existing functionality that does not work as intended
  • [x] This isn't a feature request or a discussion topic

Bug description

Disappearing messages: I understand that it's not possible to set the disappearing message to a value above 4 weeks (official doc source). On the custom parameter view, turning the number wheel of that parameter to a value above 4 and then the unit wheel to weeks always makes the number wheel back to 4. However, I noticed that putting the value at 15 and the unit wheel on weeks and then going back to the conversation view, we are told that disappearing messages will last 15 weeks.

Steps to reproduce

  • Go on the disappearing messages setting panel
  • Click on "custom value"
  • Put the number wheel on 15 (arbitrary, above 4)
  • Put the unit values to weeks

Actual result: The number is pushed back to 4 by the app. But when back to the conversation, a small message says that disappearing messages will last 15 weeks. Not sure which is the actual truth but the message is different from the setting.

Expected result: Disappearing messages should last 4 weeks, as per the official documentation.

Screenshots

In French

https://github.com/user-attachments/assets/6ff2d8c9-46a3-4579-bd39-8813e3b1267a

Device info

Device: iPhone 13 Mini

iOS version: 18.2.1

Signal version: 7.4.3 (573)

Link to debug log

https://debuglogs.org/ios/7.43.0/56d00ff58e5f1df9cbe6bbdedddac8348e1adfc71ea951db8be08951235b4aff.zip

ggrelet avatar Jan 26 '25 15:01 ggrelet

Hey there!

I'm a contributor to the repository! Thank you for reporting the bug! I made a quick fix for it!

https://github.com/user-attachments/assets/948e0236-55f5-4dd2-bac3-7823db92cc38

Here is the PR!

MarlowBrown avatar Feb 09 '25 04:02 MarlowBrown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 10 '25 07:05 stale[bot]

Keep open

On Sat, May 10, 2025 at 2:21 AM stale[bot] @.***> wrote:

stale[bot] left a comment (signalapp/Signal-iOS#5947) https://github.com/signalapp/Signal-iOS/issues/5947#issuecomment-2868572932

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-iOS/issues/5947#issuecomment-2868572932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI3H5DOBAD3ZU5O7MWXANAL25WSF7AVCNFSM6AAAAABV4ROVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRYGU3TEOJTGI . You are receiving this because you commented.Message ID: @.***>

MarlowBrown avatar May 10 '25 07:05 MarlowBrown

Is there a particular reason that the maximum retention is four weeks? Could this be extended to also have "years" as a unit?

mjklemm avatar May 26 '25 14:05 mjklemm

Thanks for reporting. This has been addressed in 65dccf9f42, which will become public with an upcoming release.

Thanks as always for being a Signal user!

sashaweiss-signal avatar May 28 '25 21:05 sashaweiss-signal