Ondra Pelech
Ondra Pelech
@jonatan-ivanov there are potential issues with concurrency when exposing the underlying clients from fs2-kafka. Are you OK with merging this PR?
When we merge this PR, we'll be able to integrate Micrometer with fs2-kafka via the `Supplier metricsSupplier`. That will be implemented via the already existing fs2-kafka's `KafkaMetrics[F[_]]#metrics: F[Map[MetricName, Metric]]` which...
> What concurrency issues would we face if we would [...] use MkConsumer and MkProducer to inject the client and also inject the same client to KafkaClientMetrics I'm not sure...
The implementation of `KafkaMetrics[F[_]]#metrics: F[Map[MetricName, Metric]]` is very special. It ensures that it calls the underlying Java Kafka client from the correct thread. Indeed, you are correct that the new...
I'm no Kafka expert, but the fs2-kafka maintainer @vlovgr has expressed concern about thread safety in this comment * https://github.com/fd4s/fs2-kafka/issues/1409#issuecomment-2969030365 > Do you know if there are any potential issues...
Hello @987Nabil , have you made the PR you've wanted?