shortbread-tilemaker

shortbread-tilemaker copied to clipboard

The argument name `ignore_bridge` is used as `ignore_bridges`. See https://github.com/shortbread-tiles/shortbread-tilemaker/blob/main/process.lua#L142-L148 But the question behind this is whether this calculation is correct even if that variable name is corrected. Shouldn't the...

joto

The implementation puts the minzoom for `highway=service` at [14](https://github.com/geofabrik/shortbread-tilemaker/blob/main/process.lua#L668-L670), the specs says 13. Also splitting the `elseif`s for zoom level 13 [here](https://github.com/geofabrik/shortbread-tilemaker/blob/main/process.lua#L665-L667) and [here](https://github.com/geofabrik/shortbread-tilemaker/blob/main/process.lua#L671-L673) seems strange.

joto

`highway=road` and `highway=platform` are not mentioned in spec but handled here.

joto

i think this is unnecessary :) https://github.com/geofabrik/shortbread-tilemaker/blob/b9ce012a575fa214eb23bae9af2f6fac3beca8ce/process.lua#L878 (unless some special styles, tools ... make use of it ?)

geoneutrino

Redundant housenumbers in `addresses` layer

4

Many housenumbers appear multiple times, which appears to be an underlying problem with OSM data anchoing different POIs to the same building. Example: Nodes `769318431`, `2423932912` and `2830792713` all point...

yetzt

Practical problems of projected `way_area` calculations

3

I believe there are practical problems with the `way_area` property calculation in the `boundary_labels` layer. I noticed the label for Norway appears over Spitzsbergen, and the `way_area` for norway is...

yetzt

Water polygons are simplified too much. You can see that in the style from [map.geofabrik.de](http://tools.geofabrik.de/map/#11/48.9850/8.4476&type=Geofabrik_Basic_Colour) at zoom level 11.0:  And if the style is created with Maputnik, zoom 11...

knowname

use new PointOnSurface of tilemaker instead of custom shapefile

1

this can now be replaced https://github.com/shortbread-tiles/shortbread-tilemaker/blob/main/boundary_labels_shape_file.md since tilemaker v3 added PointToSurface see https://github.com/systemed/tilemaker/blob/eab08d189ad97ddf5db7d915bcabe42ad3dab6af/CHANGELOG.md?plain=1#L13 and ticket https://github.com/systemed/tilemaker/issues/392 i can try to prepare a PR

oberhamsi

I think this could be a way to display the boundary labels without the shape file (See https://github.com/shortbread-tiles/shortbread-tilemaker/issues/30). Am I seeing this correctly, or am I missing something?

astridx

Use /usr/bin/env bash instead of bash directly

6

starsep