PySolFC icon indicating copy to clipboard operation
PySolFC copied to clipboard

A guide for creating custom cardsets.

Open Alucard648 opened this issue 8 years ago • 38 comments

Custom PySol cardsets outside the downloadable cardset pack are a rare thing in the Internet even in 2017. This is probably due to the fact that the config file specification is not well documented. Perhaps a guide for creating custom cardsets might solve this issue a bit.

Alucard648 avatar Aug 26 '17 00:08 Alucard648

Will you be willing to write one?

shlomif avatar Aug 26 '17 10:08 shlomif

If I would know specifications of config file which is inside each cardset folder...

Alucard648 avatar Aug 27 '17 01:08 Alucard648

Wouldn't the file specification change after adding SVG support?

Another problem with the current cardsets (and other graphical elements) is that they're of an extremely low resolution, and some are designed poorly as well... My favorite PySol's cardsets are the default one and Oxymoron. They have a nice retro feel, and look good, even though they're pixelated.

jan-kleks avatar Aug 27 '17 13:08 jan-kleks

On Sun, 27 Aug 2017 06:11:33 -0700 Jan Kleks [email protected] wrote:

Wouldn't the file specification change after adding SVG support?

Maybe, maybe not. Hopefully backward compatibility will be retained.

Another problem with the current cardsets (and other graphical elements) is that they're of an extremely low resolution, and some are designed poorly as well... My favorite PySol's cardsets are the default one and Oxymoron. They have a nice retro feel, and look good, even though they're pixelated.

--

shlomif avatar Aug 27 '17 17:08 shlomif

Adding the hacktoberfest label. Contributors are welcome.

shlomif avatar Oct 04 '17 19:10 shlomif

Perhaps a guide for creating custom cardsets might solve this issue a bit.

kdwayne described here how to do nice cardsets: https://sourceforge.net/p/pysolfc/discussion/503708/thread/6dc85931/?limit=25 In short: use cardsetmaker, set size of cards, make a fake set with any pics, exchange the files in the cardset folder with nice cards.

cardset avatar Mar 24 '19 08:03 cardset

To make things easy you could also use the most recent version of Cardset Maker 0.5 for PysolfFC

https://sourceforge.net/p/pysolfc/discussion/503708/thread/68fc17a6f5/

Here are some cardsets: http://www.andsa.de/en/pysol.html

cardset avatar Mar 21 '20 10:03 cardset

Some questions are still left unanswered:

  1. Where do I install cardsets I download? (And I hope the answer isn't "just install it in /usr/share/...".)
  2. Where is the source code for Cardset Maker, so it can be used on non-Windows computers?

ShimmerFairy avatar Sep 21 '20 20:09 ShimmerFairy

  1. For me it is .../PySol Fan Club edition/data/ Put the whole drawer of the new created cardset there

  2. The last published source was version 0.2. (Never tested on linux or mac.) But this version makes only sense for cards witch have already ranks and suites on it.

Cardset-Maker-0.2_source.zip

cardset avatar Sep 23 '20 18:09 cardset

Thanks for sharing @cardset ! The comment at the top of the .py file in the zip says it is GPLv2+. It has quite a few flake8 warnings though. @ShimmerFairy : I think you can put cardsets under ~/.PySolFC/cardsets/

shlomif avatar Sep 24 '20 06:09 shlomif

I made a tutorial to create cardsets manually. I found this was missing, because Cardset Maker doesn't give the opportunity to fully custom cardsets.

But some questions remain. For the variables I use to identify the various settings, see the attached file.

  • $A: andsa said here this corresponds to: French Sets=4 Mahjong=5 or 6, but what is this exactly ?
  • Which types could exactly be used ?
  • Could the number of cards be different than 42, 48, 52, 68, 78, 96 or 120 ?
  • Cardset location (as said here) mostly begin with a number (e.g. 12362-wilhelmtell). Is it really the location of cardsets ? Mine are in ~/.PySolFC/cardsets and it works fine.

Feel free to improve or modify my tutorial. All comments are welcome.

customize_cardset.asciidoc

Neelix57 avatar Sep 29 '20 14:09 Neelix57

I made a tutorial to create cardsets manually. I found this was missing, because Cardset Maker doesn't give the opportunity to fully custom cardsets.

But some questions remain. For the variables I use to identify the various settings, see the attached file.

  • $A: andsa said here this corresponds to: French Sets=4 Mahjong=5 or 6, but what is this exactly ?
  • Which types could exactly be used ?
  • Could the number of cards be different than 42, 48, 52, 68, 78, 96 or 120 ?
  • Cardset location (as said here) mostly begin with a number (e.g. 12362-wilhelmtell). Is it really the location of cardsets ? Mine are in ~/.PySolFC/cardsets and it works fine.

Feel free to improve or modify my tutorial. All comments are welcome.

cardsets_tutorial.txt

Thanks @Neelix57 ! Which licence is it under: https://github.com/shlomif/Freenode-programming-channel-FAQ/blob/master/FAQ_with_ToC__generated.md#i-want-to-release-my-code---which-open-source-licence-should-i-use ?

shlomif avatar Sep 29 '20 17:09 shlomif

because Cardset Maker doesn't give the opportunity to fully custom cardsets.

What is missing? (Except that it only supports poker sets)

  • Cardset location (as said here) mostly begin with a number (e.g. 12362-wilhelmtell). Is it really the location of cardsets ?

I think the prefix (1234...) is only to differ from cardsets with the same name. Nowadays i think, it is not the location. It is to give the cardset a name that makes no problems with loading/calling. For example: changing capital letters to lowercase, and filling the spaces with "-"

edit

$A: andsa said here this corresponds to: French Sets=4 Mahjong=5 or 6, but what is this exactly ?

in "resource.py" this vari is called "version" in "app.py" it seems that this vari belongs to the existing number of fields in first line. (your: $FTM;$B;$C;$D;$E;$F) )

andsa / cardset (sorry, could not get the same name on both pages)

cardset avatar Sep 29 '20 19:09 cardset

@shlomif : All my work is under GNU General Public Licence

Neelix57 avatar Sep 30 '20 07:09 Neelix57

@shlomif : All my work is under GNU General Public Licence

Thanks for the reply! Note that it has to be GPLv3-or-later or gplv2-or-later for it to be usable by PySolFC. Please clarify that this is the case.

shlomif avatar Sep 30 '20 07:09 shlomif

@cardset :

What is missing? (Except that it only supports poker sets)

The bottom images have always scare corners. I worked out with round corners cards and try to set the "Round Corners" settings for cards and backs higher but it does nothing. It works only for the cards. The other thing is the ability to customize the offsets and shadows of the cards and to give card manager's categories, because for beginner it's not too simple to work in the config file.

in "app.py" it seems that this vari belongs to the existing number of fields in first line. (your: $FTM;$B;$C;$D;$E;$F)

Yes, you're right. Thank you for the hint.

Neelix57 avatar Sep 30 '20 07:09 Neelix57

@shlomif : GPLv3 or later

Neelix57 avatar Sep 30 '20 07:09 Neelix57

@shlomif : GPLv3 or later

Thanks for the clarification, @Neelix57 !

shlomif avatar Sep 30 '20 07:09 shlomif

round corners

Do you speak about this bug? https://sourceforge.net/p/pysolfc/discussion/503708/thread/68fc17a6f5/95ae/attachment/bug-border.jpg it is solved

The other thing is the ability to customize the offsets and shadows of the cards and to give card manager's categories

Okay, i could add these futures. But from my point of view, beginners don't even know about offsets or categories. This is for somewhat experienced users. I try to find a solution that satisfy both of us. (Maybe an hopefully easy GUI for beginners and a menu for specialised things)

Even if you don't use the tool, if you (or somebody else) have ideas, or wishes please write your opinion in this thread. https://sourceforge.net/p/pysolfc/discussion/503708/thread/68fc17a6f5/

cardset avatar Sep 30 '20 11:09 cardset

Here is a screenshot of PySolFC: screenshot png As you can see, the cards have round corners, but the bottoms have square corners.

Here is something new, the corners doesn't appear correctly. It's the first time.

For test purposes, I used the existing "Paris" cardset in the pysolfc-cardsets-2.0 package.

I work with Cardset Maker 0.65 in Wine, under Xubuntu Bionic. In Cardset Maker the corners appears round but incorrect as in PySol. In facts, the cards are written in the output folder as they appears in Cardset Maker.

Neelix57 avatar Sep 30 '20 12:09 Neelix57

Okay, now i understand.

I never touched the bottom cards, because...

    1. i think layout of desk is a matter of the game itself.
    1. i never got problems with it. Screenshot: https://i.imgur.com/HtuT8sP.png

As a first test, i removed all bottom cards from my cardset, and the game still works. Then i was looking around and found corresponding graphics in "../PysolFC/data/images/cards/bottoms/" It seems they changed loading of bottom cards to this place.

Probably solution for you: Updating the game or sending an issue report. If this does not work, making the edges round in GIMP.

Solution for me: Rounding the corners of the bottoms for older versions of the game.

cardset avatar Sep 30 '20 16:09 cardset

Thank you for the information, that Cardset Maker works with Wine and Linux.This is for sure useful for other users.

cardset avatar Sep 30 '20 16:09 cardset

Then i was looking around and found corresponding graphics

Great! So many years playing PySolFC and I never found out these images, I thought the bottoms was only defined by the ones in the cardsets folders. Thanks Man.

Probably solution for you: Updating the game or sending an issue report

I don't think that were a bug. These bottoms should be default ones for cardsets created without bottoms.

Neelix57 avatar Sep 30 '20 19:09 Neelix57

I don't think that were a bug. These bottoms should be default ones for cardsets created without bottoms.

But i get them even if i have ugly bottoms in the cardsets. Should be the same for you.

cardset avatar Oct 01 '20 04:10 cardset

I take a closer look this morning. The images are squared. Nothing to do, I must use Gimp.

Neelix57 avatar Oct 01 '20 09:10 Neelix57

I take a closer look this morning. The images are squared. Nothing to do, I must use Gimp.

Just to make things clear. Is the Paris cardset made with Cardset Maker the only one which has squared corners?

I made a test. The game creates the corners like the shape of card 01c.png. Screenshot: https://i.imgur.com/y2DYTRo.png

cardset avatar Oct 01 '20 16:10 cardset

No, all cardsets have square corniers. Could it be a bug with Cardset Maker running under Wine ?

Neelix57 avatar Oct 01 '20 19:10 Neelix57

I had similar issues on a fresh install of Ubuntu Mate 20.04. This is what i did to remedy the problems. Uninstalled Pysolfc. I then installed Pysolfc using synaptic package manager. I didn't install the extra cardsets. Before i opened Pysolfc for the first time, i deleted the original cardset and replaced with one of my own. This worked perfectly, and i have added over 300 cardsets without any further issues. Another issue i had was Pysolfc would no longer recognize .jpg for table tile.(backgrounds) Using only .png files was the work around.

rexx790 avatar Oct 02 '20 01:10 rexx790

No, all cardsets have square corniers. Could it be a bug with Cardset Maker running under Wine ?

If all cardsets, have square corners, it has nothing to do with Cardset Maker. Because the older cardsets are created with something other.

cardset avatar Oct 02 '20 05:10 cardset

To my posting this morning. Of course delivers Cardset Maker wrong bottoms, i wrote this some days ago. (Not a bug, i just did not know that they are needed). The question is, are they still necessary? Or better we let PySol create the bottoms itself.

For testing, could you remove all the bottoms from your Paris cardset (Pysol closed), And start the game afterwards with the set? (if things work good, you get round corners and red hearts and diamonds) Maybe your the one who gets the correct but bad bottoms, and we fail loading and get the new ones from Pysol.

cardset avatar Oct 02 '20 18:10 cardset