operator icon indicating copy to clipboard operation
operator copied to clipboard

[BUG] Release workflow uses deprecated actions

Open adambkaplan opened this issue 2 years ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Kubernetes Version

N/A

Shipwright Version

N/A

Current Behavior

The release workflow uses deprecated actions or commands. Notably:

  1. create-release uses an EOL version of NodeJS
  2. set-output command is deprecated.

Expected Behavior

Release workflow uses up to date actions.

Steps To Reproduce

N/A

Anything else?

  • set-output deprecation: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  • NodeJS force upgrade: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

adambkaplan avatar Oct 31 '23 16:10 adambkaplan

Hi, I'd like to work on this.

jaydee029 avatar Apr 23 '24 17:04 jaydee029

@jaydee029 great! The workflow in question that we need to replace is in the .github directory linked here. If you find a similar workflow that appears to be well-maintained and kept up to date, please submit a pull request with your recommendation.

Otherwise you can write a script that uses the GitHub CLI (gh), which is available on all GitHub Actions runners. I believe this has commands which will let us draft releases.

adambkaplan avatar May 01 '24 16:05 adambkaplan

Hey @adambkaplan this does not seem to be relevant anymore

rxinui avatar Apr 25 '25 08:04 rxinui

It's still relevant - the referenced workflow is read-only: https://github.com/actions/create-release

adambkaplan avatar May 06 '25 21:05 adambkaplan