operator icon indicating copy to clipboard operation
operator copied to clipboard

refactor: Only allow one instance of `ShipwrightBuild`

Open k37y opened this issue 2 years ago • 7 comments

Changes

  • Ignore and delete the second instance

Fixes #153

Submitter Checklist

  • [ ] Includes tests if functionality changed/was added
  • [ ] Includes docs if changes are user-facing
  • [ ] Set a kind label on this PR
  • [ ] Release notes block has been filled in, or marked NONE

Release Notes

NONE

k37y avatar Oct 17 '23 12:10 k37y

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 17 '23 12:10 openshift-ci[bot]

Thank you @kevydotvinu for adding your contribution. A few points related to your PR:

  • first it is valid point to ensure that we have once instance of shipwright-build CR
  • we need to have an approach where we fix the name of the CR,and validate that name before any reonciliation (shipwright-config)
  • we would then include a targetNamespace reconcile function, that deletes the old resources if the target namespace changes
  • The change needs a release note and docs update

jkhelil avatar Oct 18 '23 07:10 jkhelil

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Nov 01 '23 22:11 openshift-merge-robot

Hello @jkhelil, thanks for reviewing. Sure, I will add those changes.

k37y avatar Nov 14 '23 19:11 k37y

@kevydotvinu please let us know if you have the time to work on this PR further. We plan on doing a significant refactor soon which will make this pull request very obsolete and hard to rebase.

adambkaplan avatar Jun 13 '24 14:06 adambkaplan

IMO, using webhook is a better user experience for this use case.

sayan-biswas avatar Jun 25 '24 12:06 sayan-biswas

I will work on it.

k37y avatar Jun 28 '24 11:06 k37y