refactor: Only allow one instance of `ShipwrightBuild`
Changes
- Ignore and delete the second instance
Fixes #153
Submitter Checklist
- [ ] Includes tests if functionality changed/was added
- [ ] Includes docs if changes are user-facing
- [ ] Set a kind label on this PR
- [ ] Release notes block has been filled in, or marked NONE
Release Notes
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thank you @kevydotvinu for adding your contribution. A few points related to your PR:
- first it is valid point to ensure that we have once instance of shipwright-build CR
- we need to have an approach where we fix the name of the CR,and validate that name before any reonciliation (shipwright-config)
- we would then include a targetNamespace reconcile function, that deletes the old resources if the target namespace changes
- The change needs a release note and docs update
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hello @jkhelil, thanks for reviewing. Sure, I will add those changes.
@kevydotvinu please let us know if you have the time to work on this PR further. We plan on doing a significant refactor soon which will make this pull request very obsolete and hard to rebase.
IMO, using webhook is a better user experience for this use case.
I will work on it.