build icon indicating copy to clipboard operation
build copied to clipboard

Provide user control over pod label

Open SaschaSchwarze0 opened this issue 5 years ago • 5 comments

Labels in Kubernetes are meant to be identifying attributes for the user, see here. As of today, a user can specify labels on all our objects for example to categorize them and to later search for them using this label.

But, we are not propagating these labels further to the TaskRun or Pod. There, we only set a set of hard-coded labels including the BuildRun, Build and BuildStrategy names. For a user, it might make sense to see his labels also on the TaskRun and Pod objects to filter them based on his own categorization.

SaschaSchwarze0 avatar Feb 26 '21 15:02 SaschaSchwarze0

implementation wise there could be some overlap with https://github.com/shipwright-io/build/issues/50 even if the scenarios / goals are not the same

gabemontero avatar Feb 26 '21 18:02 gabemontero

I'd like to pick this issue as first-time contribution. I'll come back with some draft code in the next few days

Pinolo avatar May 10 '22 08:05 Pinolo

I'd like to pick this issue as first-time contribution. I'll come back with some draft code in the next few days

Thanks @Pinolo, you can also have a look at our good-first-issue project to find issues that we assessed to be a good start.

SaschaSchwarze0 avatar May 10 '22 09:05 SaschaSchwarze0

EP created: https://github.com/shipwright-io/community/pull/86

Pinolo avatar May 16 '22 01:05 Pinolo

My colleague @alessiopiazza and me put together a draft implementation. We know it doesn't look pretty, but we didn't feel like going for a refactoring without prior discussion. Waiting for feedback on the EP, too

Pinolo avatar May 24 '22 10:05 Pinolo