build icon indicating copy to clipboard operation
build copied to clipboard

625 user control over pod labels

Open Pinolo opened this issue 3 years ago • 2 comments

Changes

  • Allows passing labels from ClusterBuildStrategy, BuildStrategy, Build, BuildRun, on to TaskRun and its pod
  • Overlapping labels in "lower" levels override "upper" levels
  • Some labels prefixes are reserved, i.e. not propagated

Fixes #625

Submitter Checklist

  • [x] Includes tests if functionality changed/was added
  • [x] Includes docs if changes are user-facing
  • [x] Set a kind label on this PR
  • [x] Release notes block has been filled in, or marked NONE

Release Notes

  • Developers and admins are now able to set labels in ClusterBuildStrategy, BuildStrategy, Build, BuildRun, that will be propagated to the pods running Tekton pipelines
  • Overlapping labels in "lower" levels override "upper" levels, i.e. if you set the same label key in both BuildStrategy resource and Build resource, the one in Build resource will be used
  • Reserved label key prefixes:
    • k8s.io
    • kubernetes.io
    • tekton.dev
    • shipwright.io
Developers and admins are now able to set labels in ClusterBuildStrategy, BuildStrategy, Build, BuildRun, that will be propagated to the pods running Tekton pipelines. Some reserved label key prefixes will not propagate:
- k8s.io
- kubernetes.io
- tekton.dev
- shipwright.io

Pinolo avatar May 24 '22 10:05 Pinolo

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign otaviof after the PR has been reviewed. You can assign the PR to them by writing /assign @otaviof in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 24 '22 10:05 openshift-ci[bot]

/kind feature

Pinolo avatar May 25 '22 10:05 Pinolo