Brendan Forster

Results 633 comments of Brendan Forster

@albinekb maybe? I'd have to remember how we did detection in WPF because I think we had similar work to do with the classic app.

Paging @donoku and @niik for general feels before I return to the C++ mines

> If someone would like to open a PR to add support for this in electron that'd be great. If I can't get to this through the inbuilt system preferences...

Seems legit: ``` var number = 10000 number.toLocaleString() ```

As discussed in #1257, we should fix this properly. See https://github.com/electron/electron/issues/9247 for the upstream issue and https://github.com/desktop/desktop/pull/1257#issuecomment-296200080 for some further context.

This idea is interesting for the future, but this is beyond the scope of our [current roadmap](https://github.com/desktop/desktop/blob/master/docs/process/roadmap.md). I added the `future-proposal` label to this issue and closed it so that...

> Reopening this issue now that [electron/electron#15035](https://github.com/electron/electron/pull/15035) exists. We should be able to get a proper fix once it lands and we update electron. Bumping this to indicate it's currently...

> I remember that many error messages aren't defined in the desktop repo. 🤔 @agisilaos they're defined over here - https://github.com/desktop/dugite/blob/master/lib/errors.ts Adding a new `GitError` enum value, and a `GitErrorRegexes`...

Dropping `help wanted` from this issue because I want to call out a workflow that ended up being attempted in #6930 that we didn't expect: **Along with showing a better...

#7120 outlines an example where selecting a large binary PDF in the changes view takes ~10s from "no file selected" to "binary file found" where there's nothing shown in-between to...