sleef icon indicating copy to clipboard operation
sleef copied to clipboard

Add basic config install

Open xsacha opened this issue 7 years ago • 9 comments

Will allow you to find with find_package(sleef) and use with target_link_libraries(${TARGET_NAME} sleef::sleef).

Only basic right now as I am unfamilar with the project and not sure if there are any special cmake defines that need to be passed through.

xsacha avatar Mar 05 '19 03:03 xsacha

@xsacha Thank you for submitting a patch. Unfortunately, the patched source code cannot be built. Please check the output from CI server and fix the problem.

https://travis-ci.org/shibatch/sleef/jobs/501824573

shibatch avatar Mar 06 '19 07:03 shibatch

Hey, sorry, I am confused by this option: option(BUILD_LIBM "libsleef will be built." ON) I don't think the text is right for this. It seems to always build this library regardless.

Specific isue with build is a CMake issue I'll have to workaround: https://cmake.org/Bug/view.php?id=14444

xsacha avatar Mar 06 '19 23:03 xsacha

Why do you need to install ${TARGET_LIBSLEEF}, ${TARGET_LIBSLEEFGNUABI} and ${TARGET_LIBDFT} at the end of the top CMakeLists.txt?

I thought what you need to additionally install is *.cmake.

shibatch avatar Mar 07 '19 04:03 shibatch

Yeah, that's how it works. I give it the TARGET and it brings in all associated libraries, dependencies, includes (unless you did them manually somewhere like the find_package).

That first attempt just didn't work because of a bug/design in that specific CMake yet it worked fine in mine (latest).

This new version should work fine in all CMake.

xsacha avatar Mar 11 '19 04:03 xsacha

@xsacha I know I am late, but I am now looking into this PR. Could you tell me how those atmark-surrounded variables work?

shibatch avatar Apr 09 '20 22:04 shibatch

@shibatch when the file is configured, as in configure_package_config_file, the @variables@ are replaced by the CMAKE variables with the same name.

xsacha avatar Apr 10 '20 00:04 xsacha

Looks good, but I think we need some kind of a tester for making sure that this functionality is not broken.

shibatch avatar Apr 10 '20 01:04 shibatch

@fpetrogalli How do you think? If you are happy with this patch, I will merge this and then add a tester.

shibatch avatar Apr 10 '20 02:04 shibatch

@shibatch #412 superseded this PR

friendlyanon avatar Apr 01 '21 13:04 friendlyanon

I'm closing this PR for the reason pointed by @friendlyanon.

blapie avatar Dec 07 '23 09:12 blapie