Nadav Ivgi

Results 207 comments of Nadav Ivgi

> At the time of sending money to the hash, you do not reveal the data so there is no way for someone to get the funds. This is true...

Thanks for reporting this! Back when I implemented thus, bwt had no arguments that could contain spaces so I didn't bother supporting them: https://github.com/bwt-dev/bwt-electrum-plugin/blob/ae06054c8e4335ed2b6f4e53d654f2c4b70cd10a/src/bwt.py#L93-L94 ... But didn't revisit this when...

Fixed by 46b6d9d09b84a76a28fd5c7b516aa2ffe4331806. You can now quote arguments, for example `--tx-broadcast-cmd "broadcast-tx {tx_hex}"`. It might take awhile to get this released in a new version, but for now you could...

> (The links in the first line don't work.) Oops, sorry, fixed them now.

To give some more context, this incompatibility resulted in electrs being unable to read db entries that were created with rust-elements v0.16 using the current master. Working around this issue...

Force-pushed the requested changes. The tests required some creativity to get it not to actually send the requests out, by overriding `req.end`. Open to other suggestions.

Is using arrow functions in the tests considered okay? Just noticed that I'm breaking the convention with that too...

> you need to start it up with the xpub(s) you want to track Does having to configure this when starting up complicate things? I could make it possible to...

> as I understand it, when you startup a bwt server you need to tell it which xpubs to track, and then it keeps indexes to track utxos for addresses...

I tried running bdk against bwt, and found an issue that is [now fixed](https://github.com/shesek/bwt/commit/55512db98b9b817c5d1f174b90a9a3dfafbc01c7) (bwt was returning an error from `blockchain.scripthash.listunspent` if the scripthash has no history, instead of returning...