webpack-plugin-serve icon indicating copy to clipboard operation
webpack-plugin-serve copied to clipboard
verified publisher icon shellscape

fix(server): remove localhost check for address

Open bhanufyi opened this issue 3 years ago • 4 comments

This PR contains:

  • [x] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] tests
  • [ ] documentation
  • [ ] metadata

Breaking Changes?

  • [ ] yes
  • [x] no

If yes, please describe the breakage.

Please Describe Your Changes

This is PR is related to an issue #239 when using custom domain which is proxied to 127.0.0.1 as host in options In the logs it shows that Server is started at http://127.0.0.1:port instead of domain name. An explicit check was added for localhost at #132 but this check doesn't allow the use of custom domain names

bhanufyi avatar Jul 01 '22 15:07 bhanufyi

I'm currently away on vacation and will check this and the associated issue when back.

shellscape avatar Jul 03 '22 03:07 shellscape

Hi @shellscape 😄, can you please have a look at this issue when you get some free time

bhanufyi avatar Aug 15 '22 17:08 bhanufyi

@bhanuprasadcherukuvada are you still using the project?

shellscape avatar Jan 14 '24 15:01 shellscape

yes

bhanufyi avatar Jan 17 '24 10:01 bhanufyi