mocha-chrome icon indicating copy to clipboard operation
mocha-chrome copied to clipboard

Fixes made by blueimp

Open eeroan opened this issue 3 years ago • 1 comments

This PR contains:

  • [x] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] tests
  • [ ] documentation
  • [x] metadata

Breaking Changes?

  • [ ] yes
  • [x] no

If yes, please describe the breakage.

Please Describe Your Changes

  • Fix incorrect mocha option colors to color
  • Define mocha >=7 as peer dependency

eeroan avatar Jun 02 '22 11:06 eeroan

I'm not sure what's going on here with the multiple contributors on the PR branch, but there's a lot not done correctly. The changes to the flags are breaking changes, which means a new major version. And that's not something that needs to happen. The user-facing flags don't need to change, and they can be passed to the internal mocha object with the correct name, without breaking for users.

shellscape avatar Jun 02 '22 18:06 shellscape