netdev icon indicating copy to clipboard operation
netdev copied to clipboard

Ideally `get_interfaces()` should return an `Iterator`

Open brainplot opened this issue 2 years ago • 3 comments

Returning some iterator type instead of the whole Vec directly would allow consumers to have more control over how memory is allocated.

This, however, would be a pretty major breaking change in the public API. If you agree with this change, I can attempt writing a PR.

brainplot avatar Oct 18 '23 20:10 brainplot

Thank you for your proposal, and I appreciate your suggestion regarding memory optimization. I agree with the proposed change. As part of my roadmap, planning to make changes to the public API up to version 1.0.0, and this memory optimization fits into efforts to enhance the library's functionality and performance.

If you have any questions or further suggestions, please feel free to let me know.

shellrow avatar Oct 24 '23 13:10 shellrow

Would you consider PRs or would you rather work on this yourself?

brainplot avatar Oct 24 '23 13:10 brainplot

Please feel free to proceed with the PR, and I'll actively review and collaborate on the changes.

shellrow avatar Oct 24 '23 14:10 shellrow