shellphish-qemu Applying qemu-cgc patch directly to qemu

Removed the patches that were applied by cloning qemu-cgc from Mechaphish. Instead, a new patch file, version.patch is being applied to the qemu version that is being cloned while building shellphish-qemu.

Oct 17 '18 22:10 g0kkk

It seems that 90% of version.patch is just removing files, which makes it unreasonably huge. Can you refactor this so those removals are done explicitly in the setup script, or maybe a removals.sh in the patches dir?

Oct 17 '18 22:10 rhelmot

Reworked on the same and that should do it.

Doesn't use a script to remove the unnecessary files though. Instead, the version.patch have been modified accordingly preserving the original conditions.

Oct 18 '18 22:10 g0kkk

version.patch is still a million lines long, probably because it includes the addition of the entire dtc repo. do we actually need that?

Oct 18 '18 22:10 rhelmot

I did not notice the dtc repo and it ain't required. I'll remove that

Oct 19 '18 01:10 g0kkk

Removed the unnecessary additions

Oct 19 '18 02:10 g0kkk

Now it includes all of pixman, which is 70% of the diff, can that go away?

Oct 19 '18 04:10 rhelmot

When that was ignored, make failed which is why that is still there.

Oct 19 '18 04:10 g0kkk

That seems extremely bad - we don't need a graphics library for emulating CGC binaries. Can you investigate why this is the case?

Oct 19 '18 04:10 rhelmot

Well, I was wrong on that part. It does work without pixman, removed it and would be pushing the same soon.

There were some other issues which actually lead to the above-mentioned pixman issues about which I came to know right now as I investigated.

Oct 19 '18 05:10 g0kkk