Simon Benzer

looks like the failing check is unrelated @diemol

was adding this to BUILD.bazel for easy testing: ``` py_test( name = "bidi_network_tests", srcs = ["test/selenium/webdriver/common/bidi_network_tests.py"], deps = [ ":init-tree", ":selenium", ":webserver", ] + TEST_DEPS, ) ``` so i could...

Think it's ready now... @AutomatedTester could you give it a look?

> I'm not a Python expert but I ended up being the person who drafted the initial BiDi implementation. I tried to avoid using the `async/await` pattern because I assumed...

> Can we add some high-level API examples and tests per an original issue? > > * driver.network.add_request_handler(...) > * driver.network.add_response_handler(...) > > This would allow us to surface the...

> I think the current tests expose the low-level API that users are not supposed to call. The high-level API unfortunately is not implemented in any bindings so there is...

tests passing locally ``` (selenium_dev_curr) (base) simonbenzer@Simons-MBP selenium % bazel test //py:bidi_network_tests WARNING: Ignoring JAVA_HOME, because it must point to a JDK, not a JRE. Starting local Bazel server and...

@p0deje Is this closer?

> > @p0deje Is this closer? > > Not quite, we need to make Request/Response be passed to the callbacks instead of plain `event`, see [#14592 (comment)](https://github.com/SeleniumHQ/selenium/pull/14592#issuecomment-2477187410) for the example....

@p0deje I did some updates based on my comment above. If I still haven't quite understood, I can just revert the commits lol