web icon indicating copy to clipboard operation
web copied to clipboard

Cowswap Trades not working on TallyHo!

Open MBMaria opened this issue 3 years ago • 0 comments

Overview

When trying to complete a TallyHo! trade, the transaction fails when using Cowswap. When turning flag off, initial trade looks like its trying to use Cowswap but after selecting Preview Trade it shows correct figures and trade completes on 0x as expected.

References and additional details

  1. Log into app.shapeshift.com and connect to TallyHo!
  2. Populate trade, select preview trade and then confirm and trade
  3. Notice the trade fails with a Something went wrong error
  4. Turn Cowswap flag off and replicate trade
  5. Notice when initially populating trade, the fees look off
  6. Preview trade and notice the fees look accurate
  7. Confirm and Trade and note the trade executes as expected image image image

Acceptance Criteria

Trades should work without having to turn flags off

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • [X] If my bounty needs engineering or needs product I have added the respective labels on the right
  • [X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.

MBMaria avatar Oct 22 '22 01:10 MBMaria