web
web copied to clipboard
"Not enough ETH for gas" error NOT showing for trades with multi account and thorswap flags on
Overview
When doing a trade on Swapper V2 with thorswap and multi account flags on, sometimes it will allow you to confirm and broadcast a transaction even if there isnt enough ETH to cover gas. Instead of giving the Not enough eth to cover gas error, it will act as if the trade is going to confirm, then the widget resets and you get a 'Something went wrong error' .
References and additional details
- Log into release.shapeshift.com and connect to native wallet
- Turn on flags for thorswap and multi account. (At this stage of testing, cowswap was turned off and V2 swapper was turned on) ( Release: https://github.com/shapeshift/web/pull/2877)
- In the trade widget create a 0x trade
- Notice that you can enter an amount of eth that when you add the gas fee, will be greater than the balance on eth available
- Select Confirm and Trade
- Notice the tx appears as if it will complete but the modal wil then reset to $0.00 and a "Something went wrong" error appears.
Acceptance Criteria
Not enough gas for eth error should appear and stop a trade from 'being confirmed' if there is not enough ETH
Need By Date
No response
Screenshots/Mockups
No response
Ownership
- [X] If my bounty needs engineering or needs product I have added the respective labels on the right
- [X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)
Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters
- Join our discord
- Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
- Please refer to this link for some basic info
- Please do not start work on this issue until you are approved in Gitcoin.
i'm going to remove this from the mobile migration milestone/label, as we're not shipping multi accounts as part of the mobile migration