web icon indicating copy to clipboard operation
web copied to clipboard
verified publisher icon shapeshift

feat: account selection FOX-ETH farming

Open gomesalexandre opened this issue 3 years ago • 1 comments

Description

This adds initial support for account selection in the FOX-ETH farming modal.

The current logic makes it so it is possible to handle accounts change, however, we still need the current logic until https://github.com/shapeshift/web/issues/2615 is implemented, so this is an intermediary, hybrid address-getting step which is needed for now.

This does not remove the accountNumber hardcoding yet.

Notice

  • [x] Have you followed the guidelines in our Contributing guide?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • [ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
  • [ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • [x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

  • tackles https://github.com/shapeshift/web/issues/2610

Risk

Reconciliation could be wrong and rug the FOX-ETH farming feature, test accordingly.

Testing

  • FOX-ETH LP and Farming cards/rows should still be displayed in the DeFi overview/earn sections both with the MultiAccount flag on and off
  • FOX-ETH LP and Farming modals should show no regressions both with the MultiAccount flag on and off

Engineering

  • Refer to the top-level steps
  • console.log/debug that setAccountId is called
  • console.log/debug that this hook runs and sets the "connected address" accordingly https://github.com/shapeshift/web/pull/2630/files#diff-6c36dba312b06e690f92edb784df2a088acf182f22a9ddea49832f491c3ae9e7R184-R191

Operations

  • Refer to the top-level steps
  • Note: with the MultiAccount Flag on, the opportunity type isn't displayed anymore, as it will be replaced by account selection:
image

Screenshots (if applicable)

gomesalexandre avatar Sep 01 '22 22:09 gomesalexandre

Current dependencies on/for this PR:

  • develop
    • PR #2643 Graphite
      • PR #2639 Graphite 👈
        • PR #2642 Graphite

This comment was auto-generated by Graphite.

gomesalexandre avatar Sep 01 '22 22:09 gomesalexandre

ETH-FOX LP and Farming are showing in on the earn opportunities list with multi account on and off correctly

0xdef1cafe avatar Sep 02 '22 16:09 0xdef1cafe

image

seeing new console error on defi page with metamask, and my FOXy balance is loading sporadically

Nice catch, inserted a new base PR in the stack (https://github.com/shapeshift/web/pull/2643) which fixes this - tl;dr is we were out of sync on the lib deps between lib packages internal deps and web

gomesalexandre avatar Sep 02 '22 17:09 gomesalexandre