web icon indicating copy to clipboard operation
web copied to clipboard

feat: move KeepKey's pin changing behavior to the wallet menu

Open NeOMakinG opened this issue 3 years ago • 0 comments

Description

  • Moved the Pin logic and markup to a reusable component and added some props needed to customize it for the menu
  • Fixed a bug crashing the app inside error handling of the new pin action
  • Added a new wallet state isUpdatingPin in order to prevent the regular modal to open when the reset pin action is launched from the menu

Notice

  • [x] Have you followed the guidelines in our Contributing guide?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • [ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
  • [ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • [x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #1414

Risk

  • The reset pin feature could be broken or buggy
  • The enter pin feature could be broken or buggy in case I did an error while moving to a reusable component

Testing

  • Connect your keepkey
  • Open the wallet menu on the top-right and try to reset the pin of the keepkey
  • Complete the whole pin reset process, everything should work as expected until the end
  • Try to also cancel, go back to the previous menu screen
  • You'll have more information in the issue, mockups and as a video in the screenshots part

Engineering

  • Connect your keepkey
  • Open the wallet menu on the top-right and try to reset the pin of the keepkey
  • Complete the whole pin reset process, everything should work as expected until the end
  • Try to also cancel, go back to the previous menu screen
  • You'll have more information in the issue, mockups and as a video in the screenshots part

Operations

  • Connect your keepkey
  • Open the wallet menu on the top-right and try to reset the pin of the keepkey
  • Complete the whole pin reset process, everything should work as expected until the end
  • Try to also cancel, go back to the previous menu screen
  • You'll have more information in the issue, mockups and as a video in the screenshots part

Screenshots (if applicable)

https://www.awesomescreenshot.com/video/10772504?key=8602abb5f2232a48617ffa3aac3f2098

NeOMakinG avatar Aug 29 '22 18:08 NeOMakinG