web icon indicating copy to clipboard operation
web copied to clipboard

Trade widget creating minimum thor swap error then reverting

Open MBMaria opened this issue 3 years ago • 0 comments

Overview

When doing a thor trade, when you put in a lower amount to trade in the pair, it comes up with an error to say the trade has a minimum amount. After leaving it for a couple seconds, the widget will update and allow the trade to go through. Only noticing it happen when initially using the trade widget. After making a few trades and swapping pairs, it doesn't seem to happen.

References and additional details

  1. Log into test branch https://bafybeidk3nuxd26ioi7outcmwl6lkhxn3lhewe3skpal6re3seunlggbmu.on.fleek.co/ and connect to kk or native wallet.
  2. Turn THOR flag on
  3. Select a thor trade pair with a low amount
  4. Notice the trade will error with a minimum amount required
  5. Leave it for a bit and notice the error will revert and you can continue with trade.

Testing PR: https://github.com/shapeshift/web/pull/2471 image image

Acceptance Criteria

Trade should not error if its allowable.

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • [X] If my bounty needs engineering or needs product I have added the respective labels on the right
  • [X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.

MBMaria avatar Aug 19 '22 22:08 MBMaria